Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one noContextMenu function in both the src/- and web/-folders #17017

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Use one noContextMenu function in both the src/- and web/-folders #17017

merged 1 commit into from
Sep 23, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

Currently we duplicate this event handler function in multiple places, which seems unnecessary.

@Snuffleupagus
Use one noContextMenu function in both the src/- and web/-folders
1df31c0 
Currently we duplicate this event handler function in multiple places, which seems unnecessary.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/65a9ee7fff2f84c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/65a9ee7fff2f84c/output.txt

Total script time: 1.47 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e282c22622f844d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cd7134598df4fb5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/cd7134598df4fb5/output.txt

Total script time: 10.76 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/cd7134598df4fb5/reftest-analyzer.html#web=eq.log

calixteman
calixteman approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e282c22622f844d/output.txt

Total script time: 21.63 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/e282c22622f844d/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 0fc0dc3 into mozilla:master Sep 23, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the one-noContextMenu branch September 23, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman